Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set - Mailing list pgsql-hackers

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Mar 30, 2022 at 10:36:16PM -0700, Andres Freund wrote:
>> On 2022-03-31 01:00:14 -0400, Tom Lane wrote:
>>> How well does this patch work with pre-14 buildfarm clients?

>> Looks to me like it'll just run the test twice, once via TestUpgrade, once via
>> taptest. It's possible that there could be trouble somehow due to duplicated
>> log files or something?

> Hmm.  TestUpgrade.pm also uses tmp_check/, and the TAP tests would
> remove this path before running.  Still, all the contents of the logs
> would be printed out before moving to the next tests at the end of
> check-pg_upgrade.  It does not seem like this double run is going to
> be an issue on this side.

Well, let's go ahead with it and see what happens.  If it's too
much of a mess we can always revert.

            regards, tom lane