Re: [COMMITTERS] pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [COMMITTERS] pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo
Date
Msg-id 4F697EE4.6090308@enterprisedb.com
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Improve the -l (limit) option recently added to contrib/vacuumlo
List pgsql-hackers
On 21.03.2012 01:05, Tom Lane wrote:
> Improve the -l (limit) option recently added to contrib/vacuumlo.
>
> Instead of just stopping after removing an arbitrary subset of orphaned
> large objects, commit and start a new transaction after each -l objects.
> This is just as effective as the original patch at limiting the number of
> locks used, and it doesn't require doing the OID collection process
> repeatedly to get everything.  Since the option no longer changes the
> fundamental behavior of vacuumlo, and it avoids a known server-side
> limitation, enable it by default (with a default limit of 1000 LOs per
> transaction).
>
> In passing, be more careful about properly quoting the names of tables
> and fields, and do some other cosmetic cleanup.

Shouldn't this be backported? Without it, vacuumlo is effectively broken 
in 9.0 and 9.1.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Reconstructing Insert queries with indirection
Next
From: Heikki Linnakangas
Date:
Subject: Re: Chronic performance issue with Replication Failover and FSM.