Re: Fix help option of contrib/oid2name - Mailing list pgsql-hackers

From Tatsuro Yamada
Subject Re: Fix help option of contrib/oid2name
Date
Msg-id 48f354af-c0f5-8b3e-e71a-82adf14f276f@lab.ntt.co.jp
Whole thread Raw
In response to Re: Fix help option of contrib/oid2name  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Fix help option of contrib/oid2name
List pgsql-hackers
> On August 18, 2018 10:52:33 AM GMT+09:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think it probably needs to stay documented, but we could mark it as
>> deprecated ...
> 
> Okay, no issues with doing so.

I revised the patch like following:

vacuumlo:
    Document
      - Add long options
      - Add environment section

oid2name:
    Document
      - Add long options
      - Add environment section
      - Remove deprecated and unhandled option "-P password"
    Code
      - Revive handling "-H host" option silently

I didn't add "-H" to the help message because it's a deprecated option.
I guess that that means "silently" as you said on previous email.
Should I add it?  For example,

    Not added "-H". (current patch)
    --------
    Connection options:
      -d, --dbname=DBNAME        database to connect to
      -h, --host=HOSTNAME        database server host or socket directory
      -p, --port=PORT            database server port number
      -U, --username=USERNAME    connect as specified database user
    --------

    Added "-H" to the help message after "-h"
    --------
    Connection options:
      -d, --dbname=DBNAME        database to connect to
      -h, -H, --host=HOSTNAME    database server host or socket directory
      -p, --port=PORT            database server port number
      -U, --username=USERNAME    connect as specified database user
    --------

Please find the attached patch.

Regards,
Tatsuro Yamada




Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [FEATURE PATCH] pg_stat_statements with plans (v02)
Next
From: Tom Lane
Date:
Subject: Re: [FEATURE PATCH] pg_stat_statements with plans (v02)