Re: [FEATURE PATCH] pg_stat_statements with plans (v02) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [FEATURE PATCH] pg_stat_statements with plans (v02)
Date
Msg-id 18200.1534735841@sss.pgh.pa.us
Whole thread Raw
In response to Re: [FEATURE PATCH] pg_stat_statements with plans (v02)  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Mon, Aug 20, 2018 at 2:55 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Can we prevent that from being allowed,
>> if we start using -std=c99?

> -Werror=vla in GCC, apparently.

Ah, cool.

> Another problem with VLAs is that they aren't in C++ and last I heard
> they aren't ever likely to be (at least not with that syntax).  I'd rather not
> introduce obstacles on that path.

While I'm not that excited about the prospect of ever moving to C++,
I'm on board with the idea of sticking to something that's a subset
of both C99 and C++.  Are there any other language features that we'd
need to avoid?  Is there a direct way of testing for that, rather
than finding per-feature warning methods?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tatsuro Yamada
Date:
Subject: Re: Fix help option of contrib/oid2name
Next
From: Michael Paquier
Date:
Subject: Re: NLS handling fixes.