Re: optimizing CleanupTempFiles - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: optimizing CleanupTempFiles
Date
Msg-id 48D246CE.1010104@enterprisedb.com
Whole thread Raw
In response to Re: optimizing CleanupTempFiles  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>> Looks like we didn't make an 
>> exception for temporary tables. Although it's harmless, we could put an 
>> isTempOrToastNamespace() test in there:
> 
> Bad, bad idea to have md.c doing any catalog access.

isTempOrToastNamespace() doesn't access catalogs, it's just checking the 
argument against two global variables. I guess you could argue that it's 
a modularity violation.
>  As already noted downthread, it wouldn't buy much anyway.

Yeah. *shrug*

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Adding new flags to XLogRecord
Next
From: Simon Riggs
Date:
Subject: Re: [PATCHES] Infrastructure changes for recovery