Re: actualised execute using patch - Mailing list pgsql-patches

From Zdenek Kotala
Subject Re: actualised execute using patch
Date
Msg-id 47E8F63F.2070409@sun.com
Whole thread Raw
In response to actualised execute using patch  ("Pavel Stehule" <pavel.stehule@gmail.com>)
Responses Re: actualised execute using patch  ("Pavel Stehule" <pavel.stehule@gmail.com>)
List pgsql-patches
you have extra space onPavel Stehule napsal(a):
> Hello
>
> http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php
>
> I actualized this patch for current CVS

Hi Pavel,

I tested your patch and it works regarding to proposal. However
I have some small comments:

1) you have extra space in ./src/pl/plpgsql/src/gram.y on line 1351

2) there is some Czech text in regression tests diffs

3) I would like to add two more tests:

a) test which check if execute really takes 3rd parameter and inject it as a
first one:

create or replace function test(int,int,int) returns int as $$
declare
   a int;
begin
  execute 'select $1' into a using $3;
  return a;
end
  $$ language plpgsql;
select test(1,2,3);

b) and second test which control number of arguments:

for example:

create or replace function test(int,int,int) returns int as $$
begin
  execute 'select $3' into a using $1;
  return a;
end
  $$ language plpgsql;
select test(1,2,3);



            Zdenek


pgsql-patches by date:

Previous
From: Martin Pihlak
Date:
Subject: Re: stored procedure stats in collector
Next
From: Alvaro Herrera
Date:
Subject: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1