Thread: actualised execute using patch

Hello

http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php

I actualized this patch for current CVS

Regards
Pavel Stehule

you have extra space onPavel Stehule napsal(a):
> Hello
>
> http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php
>
> I actualized this patch for current CVS

Hi Pavel,

I tested your patch and it works regarding to proposal. However
I have some small comments:

1) you have extra space in ./src/pl/plpgsql/src/gram.y on line 1351

2) there is some Czech text in regression tests diffs

3) I would like to add two more tests:

a) test which check if execute really takes 3rd parameter and inject it as a
first one:

create or replace function test(int,int,int) returns int as $$
declare
   a int;
begin
  execute 'select $1' into a using $3;
  return a;
end
  $$ language plpgsql;
select test(1,2,3);

b) and second test which control number of arguments:

for example:

create or replace function test(int,int,int) returns int as $$
begin
  execute 'select $3' into a using $1;
  return a;
end
  $$ language plpgsql;
select test(1,2,3);



            Zdenek

On 25/03/2008, Zdenek Kotala <Zdenek.Kotala@sun.com> wrote:
> you have extra space onPavel Stehule napsal(a):
>
> > Hello
>  >
>  > http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php
>  >
>  > I actualized this patch for current CVS
>
>
> Hi Pavel,
>
>  I tested your patch and it works regarding to proposal. However
>  I have some small comments:
>
>  1) you have extra space in ./src/pl/plpgsql/src/gram.y on line 1351

I didn't find it
>
>  2) there is some Czech text in regression tests diffs
>

fixed

>  3) I would like to add two more tests:
>
>  a) test which check if execute really takes 3rd parameter and inject it as a
>  first one:
>
>  create or replace function test(int,int,int) returns int as $$
>  declare
>    a int;
>  begin
>   execute 'select $1' into a using $3;
>   return a;
>  end
>   $$ language plpgsql;
>  select test(1,2,3);
>
>  b) and second test which control number of arguments:
>
>  for example:
>
>  create or replace function test(int,int,int) returns int as $$
>  begin
>   execute 'select $3' into a using $1;
>   return a;
>  end
>   $$ language plpgsql;
>  select test(1,2,3);
>

I did it
>
>
>
>                         Zdenek
>
>