Re: strange result from contrib/seg regression on windows - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: strange result from contrib/seg regression on windows
Date
Msg-id 4172E7D8.1000403@dunslane.net
Whole thread Raw
In response to Re: strange result from contrib/seg regression on windows  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>Does anyone have a clue why?
>>    
>>
>
>Evidently your sscanf isn't setting errno for overflow --- look at
>seg_atof() in segparse.y.
>
>
>This code shows several other signs of severe brain death, actually,
>like leaking 256 bytes on each call for an error message buffer that it
>doesn't even need :-(  I'd recommend ripping the whole thing out and
>replacing with a call to float4in.
>
>
>  
>

Yeah. If anyone can do this quickly I'd be grateful. Otherwise it will 
probably be a few days before I get it done.

Alternatively, could we not just use strtof instead of sscanf?

cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Open Items
Next
From: Mark Kirkwood
Date:
Subject: Re: plans for bitmap indexes?