Postgres Pro
Downloads
Home   >   mailing lists

Re: strange result from contrib/seg regression on windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: strange result from contrib/seg regression on windows
Date
Msg-id 10333.1098042565@sss.pgh.pa.us
Whole thread Raw
In response to strange result from contrib/seg regression on windows  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: strange result from contrib/seg regression on windows
List pgsql-hackers
Tree view 
Andrew Dunstan <andrew@dunslane.net> writes:
> Does anyone have a clue why?

Evidently your sscanf isn't setting errno for overflow --- look at
seg_atof() in segparse.y.


This code shows several other signs of severe brain death, actually,
like leaking 256 bytes on each call for an error message buffer that it
doesn't even need :-(  I'd recommend ripping the whole thing out and
replacing with a call to float4in.
        regards, tom lane

pgsql-hackers by date:

Previous
From:
Date:
Subject: Re: [HACKERS] Getting rid of AtEOXact Buffers (was Re: [Testperf-general] Re: First set of OSDL Shared Memscalability results, some wierdness ...)
Next
From: Tom Lane
Date:
Subject: Re: Re: [HACKERS] Getting rid of AtEOXact Buffers (was Re: [Testperf-general] Re: First set of OSDL Shared Memscalability results, some wierdness ...)