Re: Bug with view definitions? - Mailing list pgsql-hackers

From Christopher Kings-Lynne
Subject Re: Bug with view definitions?
Date
Msg-id 40EA1BD0.1060702@familyhealth.com.au
Whole thread Raw
In response to Re: Bug with view definitions?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bug with view definitions?
Re: Bug with view definitions?
List pgsql-hackers
>>  need_paren = (PRETTY_PAREN(context) ?
>>                                !IsA(op->rarg, RangeTblRef) : true);
> 
> 
> In a quick glance this code seems close to completely brain dead :-(
> For one thing, why isn't it making separate determinations about whether
> the left and right inputs of the UNION (resp INTERSECT or EXCEPT)
> operator need to be parenthesized?  After that maybe we could figure out
> what the individual decisions need to be.

So what are we going to do about it?

Was it one of the pgAdmin guys who wrote it in the first place?

Chris



pgsql-hackers by date:

Previous
From: "Marc G. Fournier"
Date:
Subject: Re: compile errors in new PL/Pler
Next
From: Tom Lane
Date:
Subject: Re: Bug with view definitions?