Re: Think-o in foreign key comments - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Think-o in foreign key comments
Date
Msg-id 3c87f4db-560b-d9b7-77f4-bdb67e0d122b@enterprisedb.com
Whole thread Raw
In response to Re: Think-o in foreign key comments  (Ian Lawrence Barwick <barwick@gmail.com>)
List pgsql-hackers
On 03.12.22 05:59, Ian Lawrence Barwick wrote:
> 2022年12月3日(土) 7:19 Paul Jungwirth <pj@illuminatedcomputing.com>:
>> I noticed a few places in the new foreign key code where a comment says
>> "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
>> DELETE SET NULL/DEFAULT".
>>
>> These comments were added in d6f96ed94e7, "Allow specifying column list
>> for foreign key ON DELETE SET actions." Here is a patch to correct them.
> 
> LGTM.
> 
> I do notice the same patch adds the function "validateFkOnDeleteSetColumns"
> but the name in the comment preceding it is "validateFkActionSetColumns",
> might as well fix that the same time.

Committed with that addition and backpatched to PG15.




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Error-safe user functions
Next
From: "David G. Johnston"
Date:
Subject: Re: Error-safe user functions