Re: driver source code indentation - Mailing list pgsql-jdbc

From Barry Lind
Subject Re: driver source code indentation
Date
Msg-id 3B952ED9.3010805@xythos.com
Whole thread Raw
In response to driver source code indentation  (Liam Stewart <liams@redhat.com>)
Responses Re: driver source code indentation
Re: driver source code indentation
List pgsql-jdbc
I agree that this is needed.  In fact I know Bruce wants to do something
in this area.  In fact he sent out a few months ago a sample of the code
after it had been cleaned up by some tool.  At the time no one seemed to
be very interested.  Going forward for 7.2 I think now is the time that
something should be done.  We need the equivalent of pgindent for java.

I am OK with the style used for the C code.  However I would like the
following additional step done for the java code:  replace all tabs with
spaces.

I often end up viewing files in editors/viewers other than the one I
normally code with.  Having to worry about getting the tab settings
correct so that the code is readable is a pain (and sometimes not
possible depending on the editor).  I have personally adopted in my java
IDE of choice (JBuilder) to have the IDE automatically replace tabs with
spaces for this reason.

thanks,
--Barry


Liam Stewart wrote:
> I suggest that the JDBC driver adopt PostgreSQL's indentation standards
> (see PostgreSQL developers FAQ, question 1). I see that some source
> files have used this standard, but the vast majority do not. We should
> have a standard for consistency and our own sanity if nothing else.
>
> Liam
>
>



pgsql-jdbc by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: driver source code indentation
Next
From: Liam Stewart
Date:
Subject: Re: driver source code indentation