Re: driver source code indentation - Mailing list pgsql-jdbc

From Bruce Momjian
Subject Re: driver source code indentation
Date
Msg-id 200109041925.f84JPX527305@candle.pha.pa.us
Whole thread Raw
In response to driver source code indentation  (Liam Stewart <liams@redhat.com>)
Responses Re: driver source code indentation  (Liam Stewart <liams@redhat.com>)
Re: driver source code indentation  (Anders Bengtsson <ndrsbngtssn@yahoo.se>)
Re: driver source code indentation  ("Dave Cramer" <Dave@micro-automation.net>)
Re: driver source code indentation  (Rene Pijlman <rene@lab.applinet.nl>)
List pgsql-jdbc
>
> I suggest that the JDBC driver adopt PostgreSQL's indentation standards
> (see PostgreSQL developers FAQ, question 1). I see that some source
> files have used this standard, but the vast majority do not. We should
> have a standard for consistency and our own sanity if nothing else.

Glad someone brought this up.  A while ago I wrote:

    I tried pgindent but it doesn't understand Java and made a mess of it.
    I used astyle with the options:

            $ astyle --style=java -j *.java

    I have the reformatted jdbc files at:

            ftp://candle.pha.pa.us/pub/postgresql/astyle_jdbc.tar.gz

    I must say it looks very good.

Can people tak a look at that and see if they like it?  I will work on
astyle to find a format that matches the main code indenting.

If you like it, I will indent just after we go beta.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-jdbc by date:

Previous
From: "chris markiewicz"
Date:
Subject: Re: error - NOTICE: current transaction...MORE DETAIL...
Next
From: Barry Lind
Date:
Subject: Re: driver source code indentation