Re: [HACKERS] create database doesn't work well in MULTIBYTE mode - Mailing list pgsql-hackers

From Thomas Lockhart
Subject Re: [HACKERS] create database doesn't work well in MULTIBYTE mode
Date
Msg-id 38AC0F97.5400498C@alumni.caltech.edu
Whole thread Raw
In response to RE: [HACKERS] create database doesn't work well in MULTIBYTE mode  ("Hiroshi Inoue" <Inoue@tpf.co.jp>)
Responses Re: [HACKERS] create database doesn't work well in MULTIBYTE mode  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
> $6 is already converted from string to ival in another place.
> It seems to me that this change is unnecessary.
> I don't understand why this was changed recently.

At the moment, if the code is compiled without MULTIBYTE enabled, it
will silently ignore any "ENCODING=" clause in a CREATE DATABASE
statement.

Wouldn't it be more appropriate to throw an elog(ERROR) in this case
(or perhaps an elog(WARN))? I've got the code ready to add in.
Comments?
                  - Thomas

-- 
Thomas Lockhart                lockhart@alumni.caltech.edu
South Pasadena, California


pgsql-hackers by date:

Previous
From: Thomas Lockhart
Date:
Subject: Re: [HACKERS] PC Week PostgreSQL benchmark results posted online (fwd)
Next
From: Thomas Lockhart
Date:
Subject: Re: [HACKERS] Almost there on column aliases