Re: BUG #1490: contrib .sql.in sed command bogus - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #1490: contrib .sql.in sed command bogus
Date
Msg-id 3835.1109031416@sss.pgh.pa.us
Whole thread Raw
In response to BUG #1490: contrib .sql.in sed command bogus  ("Alexis Wilke" <alexis@m2osw.com>)
Responses Re: BUG #1490: contrib .sql.in sed command bogus  (alexis@m2osw.com)
List pgsql-bugs
"Alexis Wilke" <alexis@m2osw.com> writes:
> Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
> proper path in the final .sql file:


> ifneq (,$(MODULES)$(MODULE_big))
> %.sql: %.sql.in
>     sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
> endif

This is not correct --- the substitution is supposed to be literally
"$libdir", and so the makefile is correct as-is.  (I'm not sure why we
still bother with doing the sed conversion at all, except that if we
removed it you can be sure we'd think of some other thing we needed it
for ;-))

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #1495: RPM: wrong quoting of error message about old database format after upgrading
Next
From: Tom Lane
Date:
Subject: Re: BUG #1491: Getting an "undefined symbol" when loading contrib mod.