Re: BUG #1490: contrib .sql.in sed command bogus - Mailing list pgsql-bugs

From alexis@m2osw.com
Subject Re: BUG #1490: contrib .sql.in sed command bogus
Date
Msg-id Pine.LNX.4.44.0502212227110.11342-100000@substitute
Whole thread Raw
In response to Re: BUG #1490: contrib .sql.in sed command bogus  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Hi Tom,

Indeed, with the correct version the $libdir will work in the .sql file.
Very good. 8-)

Alexis

On Mon, 21 Feb 2005, Tom Lane wrote:

> "Alexis Wilke" <alexis@m2osw.com> writes:
> > Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
> > proper path in the final .sql file:
>
>
> > ifneq (,$(MODULES)$(MODULE_big))
> > %.sql: %.sql.in
> >     sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
> > endif
>
> This is not correct --- the substitution is supposed to be literally
> "$libdir", and so the makefile is correct as-is.  (I'm not sure why we
> still bother with doing the sed conversion at all, except that if we
> removed it you can be sure we'd think of some other thing we needed it
> for ;-))
>
>             regards, tom lane
>

pgsql-bugs by date:

Previous
From: "Nicolas Rachinsky"
Date:
Subject: BUG #1504: Wrong user is used for sequences through rules
Next
From: "Luke Lincoln"
Date:
Subject: BUG #1499: Unable to install