Postgres Pro
Downloads
Home   >   mailing lists

Re: invalid data in file backup_label problem on windows - Mailing list pgsql-hackers

From David Steele
Subject Re: invalid data in file backup_label problem on windows
Date
Msg-id 30780930-abab-2d1c-32a0-597604765e69@pgmasters.net
Whole thread Raw
In response to Re: invalid data in file backup_label problem on windows  (Magnus Hagander <magnus@hagander.net>)
Responses Re: invalid data in file backup_label problem on windows  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 3/29/21 4:34 AM, Magnus Hagander wrote:
> On Mon, Mar 29, 2021 at 7:01 AM Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Sun, Mar 28, 2021 at 09:29:10AM -0400, Andrew Dunstan wrote:
>>> -     vital to the backup working, and must be written without modification.
>>> +     vital to the backup working and must be written without
>>> modification, which
>>> +     may include opening the file in binary mode.
>>
>> += "on Windows"?
> 
> I'd say no, better to just tell people to always open the file in
> binary mode. It's not hurtful anywhere, there's really no reason ever
> to open it in text mode.

Agreed. New patch attached.

Regards,
-- 
-David
david@pgmasters.net
Attachment

pgsql-hackers by date:

Previous
From: Denis Hirn
Date:
Subject: Re: [PATCH] Allow multiple recursive self-references
Next
From: Arseny Sher
Date:
Subject: Re: Flaky vacuum truncate test in reloptions.sql