Re: invalid data in file backup_label problem on windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: invalid data in file backup_label problem on windows
Date
Msg-id YGUaIiYW32aok3S2@paquier.xyz
Whole thread Raw
In response to Re: invalid data in file backup_label problem on windows  (David Steele <david@pgmasters.net>)
Responses Re: invalid data in file backup_label problem on windows  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Mar 31, 2021 at 09:33:25AM -0400, David Steele wrote:
> Agreed. New patch attached.

Thanks, David.

> diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml
> index c5557d5444..8c9186d277 100644
> --- a/doc/src/sgml/backup.sgml
> +++ b/doc/src/sgml/backup.sgml
> @@ -913,7 +913,8 @@ SELECT * FROM pg_stop_backup(false, true);
>       <filename>backup_label</filename> in the root directory of the backup. The
>       third field should be written to a file named
>       <filename>tablespace_map</filename> unless the field is empty. These files are
> -     vital to the backup working, and must be written without modification.
> +     vital to the backup working and must be written byte for byte without
> +     modification, which may require opening the file in binary mode.

Okay, that sounds good to me.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Issue with point_ops and NaN
Next
From: Peter Geoghegan
Date:
Subject: Re: New IndexAM API controlling index vacuum strategies