Postgres Pro
Downloads
Home   >   mailing lists

Re: Use of PG_BINARY_R and "r" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use of PG_BINARY_R and "r"
Date
Msg-id 2919.1016823859@sss.pgh.pa.us
Whole thread Raw
In response to Use of PG_BINARY_R and "r"  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Use of PG_BINARY_R and "r"  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Tree view 
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> My assumption is that text files should use "r" and binary files use
> PG_BINARY_R.

I believe that's correct.  It seems kinda inconsistent though.

> For example, in 7.2 I see pg_hba.conf opened with "r" and pg_ident.conf
> opened with PG_BINARY_R.

The latter is clearly wrong, since pg_ident.conf is not binary.

Is there any interest in defining#define PG_TEXT_R "r"#define PG_TEXT_W "w"
so that AllocateFile is always called with one of this set of macros?
Or is that just silly?
        regards, tom lane

pgsql-hackers by date:

Previous
From: "Ross J. Reedstrom"
Date:
Subject: Re: SET NULL / SET NOT NULL
Next
From: Tom Lane
Date:
Subject: Re: SET NULL / SET NOT NULL