Use of PG_BINARY_R and "r" - Mailing list pgsql-hackers

I am seeing conflicting usage of PG_BINARY_R and "r" in AllocateFile()
calls.  Is there a logic of when to use one or the other, or is this
just badly maintained code?

The significant difference is:#ifdef __CYGWIN__#define PG_BINARY    O_BINARY#define PG_BINARY_R "rb"#define PG_BINARY_W
"wb"#else#definePG_BINARY    0#define PG_BINARY_R "r"#define PG_BINARY_W "w"#endif
 

For example, in 7.2 I see pg_hba.conf opened with "r" and pg_ident.conf
opened with PG_BINARY_R.

My assumption is that text files should use "r" and binary files use
PG_BINARY_R.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026