Re: Parsing config files in a directory - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Parsing config files in a directory
Date
Msg-id 28179.1256566747@sss.pgh.pa.us
Whole thread Raw
In response to Re: Parsing config files in a directory  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Parsing config files in a directory
Re: Parsing config files in a directory
Re: Parsing config files in a directory
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Maybe SET PERSISTENT needs to go back to postgresql.conf, add an
> automatic comment "# overridden in persistent.conf" and put a comment
> marker in front of the original line.  That way the user is led to the
> actual authoritative source.

Doesn't that require the same AI-complete parsing ability we have said
we don't want to implement?

Personally I think this is just a matter of usage.  If you want to use
SET PERSISTENT, don't set values manually in postgresql.conf.  How is
that different from the existing rule that if you want to set values in
postgresql.conf, you'd better not set them on the postmaster command
line?

> Fortunately we now have an easy way to find out which file is each
> setting's value coming from.

Yeah --- that feature should make it easy enough to debug any conflicts.

I think we shouldn't overthink this.  The separate file with a clear
warning to not edit it manually seems like a fine approach from here.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal: String key space for advisory locks
Next
From: Alvaro Herrera
Date:
Subject: Re: Parsing config files in a directory