Re: Parsing config files in a directory - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Parsing config files in a directory
Date
Msg-id 20091026140638.GC8812@alvh.no-ip.org
Whole thread Raw
In response to Re: Parsing config files in a directory  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Parsing config files in a directory
Re: Parsing config files in a directory
List pgsql-hackers
Robert Haas escribió:
> On Mon, Oct 26, 2009 at 12:18 AM, Greg Smith <gsmith@gregsmith.com> wrote:

> > It actually makes it completely trivial to implement.  SET PERSISTENT can
> > now write all the changes out to a new file in the include directory. Just
> > ship the database with a persistent.conf in there that looks like this:
> 
> This only sorta works.  If the changes are written out to a file that
> is processed after postgresql.conf (or some other file that contains
> values for those variables), then someone who edits postgresql.conf
> (or some other file) by hand will think they have changed a setting
> when they really haven't.

Maybe SET PERSISTENT needs to go back to postgresql.conf, add an
automatic comment "# overridden in persistent.conf" and put a comment
marker in front of the original line.  That way the user is led to the
actual authoritative source.


> On the flip side, there could also be still
> other files that are processed afterwards, in which case SET
> PERSISTENT would appear to work but not actually do anything.

Fortunately we now have an easy way to find out which file is each
setting's value coming from.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: License clarification: BSD vs MIT
Next
From: Tom Lane
Date:
Subject: Re: Proposal: String key space for advisory locks