Re: compiler warnings on the buildfarm - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compiler warnings on the buildfarm
Date
Msg-id 27687.1184290111@sss.pgh.pa.us
Whole thread Raw
In response to Re: compiler warnings on the buildfarm  (Kris Jurka <books@ejurka.com>)
Responses Re: compiler warnings on the buildfarm  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-hackers
Kris Jurka <books@ejurka.com> writes:
> So pam_message ** isn't const.

Ah, thanks.  I see luna_moth is giving the same warning, so it's still
not const in Solaris 11 either.

Is it worth working around this?  It's strictly cosmetic AFAICS.

The main issue in my mind would be how to determine whether to use
const or not.  If all Solaris releases are like this, and can be
expected to stay that way, I'd be inclined to just put a "#define
PAM_CONV_PROC_NOT_CONST" in include/port/solaris.h and drive the
function declaration off that.  If there's a version dependency
involved then it gets a lot more complicated, and might not be worth
the trouble.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: compiler warnings on the buildfarm
Next
From: Jeremy Drake
Date:
Subject: Re: compiler warnings on the buildfarm