Re: patch adding new regexp functions - Mailing list pgsql-patches

From Tom Lane
Subject Re: patch adding new regexp functions
Date
Msg-id 27337.1174484748@sss.pgh.pa.us
Whole thread Raw
In response to Re: patch adding new regexp functions  (Jeremy Drake <pgsql@jdrake.com>)
Responses Re: patch adding new regexp functions
List pgsql-patches
Jeremy Drake <pgsql@jdrake.com> writes:
> BTW, should I be calling
> get_typlenbyvalalign on TEXTOID or are there macros for those also?

By and large we tend to hard-wire those properties too, eg there are
plenty of places that do things like this:

    /* XXX: this hardcodes assumptions about the regtype type */
    result = construct_array(tmp_ary, num_params, REGTYPEOID, 4, true, 'i');

Some are better commented than others ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Gregory Stark
Date:
Subject: Re: patch adding new regexp functions
Next
From: "Simon Riggs"
Date:
Subject: Re: Make CLUSTER MVCC-safe