Re: Remove some useless casts to (void *) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove some useless casts to (void *)
Date
Msg-id 2542ac5a-5dc6-608a-f9f1-360e11652826@enterprisedb.com
Whole thread Raw
In response to Re: Remove some useless casts to (void *)  (Corey Huinker <corey.huinker@gmail.com>)
List pgsql-hackers
On 03.02.23 00:59, Corey Huinker wrote:
> On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut 
> <peter.eisentraut@enterprisedb.com 
> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
> 
>     I have found that in some corners of the code some calls to standard C
>     functions are decorated with casts to (void *) for no reason, and this
>     code pattern then gets copied around.  I have gone through and cleaned
>     this up a bit, in the attached patches.
> 
>     The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
>     qsort, bsearch
> 
>     Also hash_search(), for which there was a historical reason (the
>     argument used to be char *), but not anymore.
> 
> 
> +1

committed

> All code is example code.

I like that one!




pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Make mesage at end-of-recovery less scary.
Next
From: Richard Guo
Date:
Subject: A bug in make_outerjoininfo