Postgres Pro
Downloads
Home   >   mailing lists

Thread: Remove some useless casts to (void *)

Remove some useless casts to (void *)

From
Peter Eisentraut
Date:
I have found that in some corners of the code some calls to standard C 
functions are decorated with casts to (void *) for no reason, and this 
code pattern then gets copied around.  I have gone through and cleaned 
this up a bit, in the attached patches.

The involved functions are: repalloc, memcpy, memset, memmove, memcmp, 
qsort, bsearch

Also hash_search(), for which there was a historical reason (the 
argument used to be char *), but not anymore.
Attachment

Re: Remove some useless casts to (void *)

From
Corey Huinker
Date:


On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
I have found that in some corners of the code some calls to standard C
functions are decorated with casts to (void *) for no reason, and this
code pattern then gets copied around.  I have gone through and cleaned
this up a bit, in the attached patches.

The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
qsort, bsearch

Also hash_search(), for which there was a historical reason (the
argument used to be char *), but not anymore.

+1

All code is example code.

Applies.
Passes make check world.
 

Re: Remove some useless casts to (void *)

From
Peter Eisentraut
Date:
On 03.02.23 00:59, Corey Huinker wrote:
> On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut 
> <peter.eisentraut@enterprisedb.com 
> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
> 
>     I have found that in some corners of the code some calls to standard C
>     functions are decorated with casts to (void *) for no reason, and this
>     code pattern then gets copied around.  I have gone through and cleaned
>     this up a bit, in the attached patches.
> 
>     The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
>     qsort, bsearch
> 
>     Also hash_search(), for which there was a historical reason (the
>     argument used to be char *), but not anymore.
> 
> 
> +1

committed

> All code is example code.

I like that one!