Thanks!
At Fri, 3 Feb 2023 15:16:02 +0100, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote in
> So this patch is now failing because it applies new tests to
> 011_crash_recovery.pl, which was removed recently. Can you please move
> them elsewhere?
I don't find an appropriate file to move to. In the end I created a
new file with the name 034_recovery.pl. I added a test for standbys,
too. (which is the first objective of this patch.)
> I think the comment for ValidXLogRecordLength should explain what the
> return value is.
Agreed.
/*
* Validate record length of an XLOG record header.
*
* This is substantially a part of ValidXLogRecordHeader. But XLogReadRecord
* needs this separate from the function in case of a partial record header.
+ *
+ * Returns true if the xl_tot_len header field has a seemingly valid value,
+ * which means the caller can proceed reading to the following part of the
+ * record.
*/
static bool
ValidXLogRecordLength(XLogReaderState *state, XLogRecPtr RecPtr,
I added a similar description to ValidXLogRecordHeader.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
