Re: pgsql: Add suport for server-side LZ4 base backup compression. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date
Msg-id 2460218.1644704163@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add suport for server-side LZ4 base backup compression.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgsql: Add suport for server-side LZ4 base backup compression.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, Feb 12, 2022 at 5:09 PM Andres Freund <andres@anarazel.de> wrote:
>> I don't think there's an actual configure check for the lz4 binary? Looks like
>> a static assignment in src/Makefile.global.in to me.

> Oh. That seems kind of dumb.

It looks to me like somebody figured it didn't need any more support
than gzip/bzip2, which is wrong on a couple of grounds:
* hardly any modern platforms lack those, unlike lz4
* we don't invoke either one of them during testing, only when
  you explicitly ask to make a compressed tarball

I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Next
From: Andres Freund
Date:
Subject: Re: Adding CI to our tree