Re: pgsql: Add suport for server-side LZ4 base backup compression. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date
Msg-id CA+Tgmobva6NRLtp=8z3V8EzmwryOdfZwBy+8NUf8aQH5B9p-1A@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add suport for server-side LZ4 base backup compression.  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Add suport for server-side LZ4 base backup compression.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Feb 12, 2022 at 5:09 PM Andres Freund <andres@anarazel.de> wrote:
> On 2022-02-12 07:24:46 -0500, Robert Haas wrote:
> > You may be right, but I'm not entirely convinced. $ENV{'LZ4'} here is
> > being set by make, and make is setting it to whatever configure found.
> > If configure found a version of the lz4 program that doesn't actually
> > work, isn't that configure's fault, or the system administrator's
> > fault, rather than this test's fault?
>
> I don't think there's an actual configure check for the lz4 binary? Looks like
> a static assignment in src/Makefile.global.in to me.

Oh. That seems kind of dumb.

It does mean that trying to run it is all that we can do, though,
because we don't have a full path.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.