Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional - Mailing list pgsql-hackers

From David Steele
Subject Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional
Date
Msg-id 22d564fc-545f-d242-fef1-b33dac9ac1f6@pgmasters.net
Whole thread Raw
In response to Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: PATCH: Make pg_stop_backup() archive wait optional  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On 3/22/17 4:42 PM, Peter Eisentraut wrote:
> On 3/22/17 15:14, Stephen Frost wrote:
>>> -SELECT * FROM pg_stop_backup(false);
>>> +SELECT * FROM pg_stop_backup(false [, true ]);
>>>
>>> I think that it's better to get rid of "[" and "]" from the above because
>>> IMO this should be the command example that users actually can run.
>> Using the '[' and ']' are how all of the optional arguments are
>> specified in the documentation, see things like current_setting() in our
>> existing documentation:
>
> In the synopsis, but not in concrete examples.

Wasn't quite sure what the protocol was in this case, and figured it was 
easier to subtract than to add.

-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: [HACKERS] increasing the default WAL segment size
Next
From: David Steele
Date:
Subject: Re: [HACKERS] increasing the default WAL segment size