Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional
Date
Msg-id 4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional  (Stephen Frost <sfrost@snowman.net>)
Responses Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional  (Stephen Frost <sfrost@snowman.net>)
Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional  (David Steele <david@pgmasters.net>)
List pgsql-hackers
On 3/22/17 15:14, Stephen Frost wrote:
>> -SELECT * FROM pg_stop_backup(false);
>> +SELECT * FROM pg_stop_backup(false [, true ]);
>>
>> I think that it's better to get rid of "[" and "]" from the above because
>> IMO this should be the command example that users actually can run.
> Using the '[' and ']' are how all of the optional arguments are
> specified in the documentation, see things like current_setting() in our
> existing documentation:

In the synopsis, but not in concrete examples.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.
Next
From: Stephen Frost
Date:
Subject: Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional