Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.
Date
Msg-id 22736.1210613735@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
Magnus Hagander <magnus@hagander.net> writes:
> I need to leave for a couple of hours, will look again when I get back.
> But so far, I'm quite surprised. Here's my reasoning, please poke holes
> in it :-)

I think you forgot to handle SYNC_METHOD_OPEN_DSYNC in issue_xlog_fsync.
If you are going to split SYNC_METHOD_OPEN into two codes, you need to
handle both those codes everywhere SYNC_METHOD_OPEN was formerly
referenced ...
        regards, tom lane

pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Syntax decisions for pl/pgsql RAISE extension
Next
From: "Brendan Jurd"
Date:
Subject: Re: Syntax decisions for pl/pgsql RAISE extension