Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls
Date
Msg-id 202504131212.7awgygnfvtef@alvherre.pgsql
Whole thread Raw
In response to Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls
List pgsql-hackers
On 2025-Apr-12, Andrew Dunstan wrote:

> Seems odd that this one is necessary at all. Doesn't a StringInfo always
> have a trailing null byte?

AFAICT what this is doing that's significant, is increment StringInfo->len.
Before doing it, the NUL byte is not part of the message; afterwards it
is.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"The important things in the world are problems with society that we don't
understand at all. The machines will become more complicated but they won't
be more complicated than the societies that run them."    (Freeman Dyson)



pgsql-hackers by date:

Previous
From: wenhui qiu
Date:
Subject: Re: TOAST versus toast
Next
From: Mahendra Singh Thalor
Date:
Subject: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error