Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls
Date
Msg-id aecf01fe-dbf1-4892-8d39-d58dc60f78e6@dunslane.net
Whole thread Raw
In response to Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
On 2025-04-13 Su 8:12 AM, Álvaro Herrera wrote:
> On 2025-Apr-12, Andrew Dunstan wrote:
>
>> Seems odd that this one is necessary at all. Doesn't a StringInfo always
>> have a trailing null byte?
> AFAICT what this is doing that's significant, is increment StringInfo->len.
> Before doing it, the NUL byte is not part of the message; afterwards it
> is.
>


That make sense, but then it would be nice to have the accompanying 
comment a bit clearer.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: 贾明伟
Date:
Subject: Re: CSN snapshots in hot standby
Next
From: Andrew Dunstan
Date:
Subject: Re: Buildfarm: Enabling injection points on basilisk/dogfish (Alpine / musl)