Re: Thoughts on using Text::Template for our autogenerated code? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Thoughts on using Text::Template for our autogenerated code?
Date
Msg-id 20230330213348.zqhyabdomtmuc4x7@awork3.anarazel.de
Whole thread Raw
In response to Re: Thoughts on using Text::Template for our autogenerated code?  (Corey Huinker <corey.huinker@gmail.com>)
Responses Re: Thoughts on using Text::Template for our autogenerated code?
List pgsql-hackers
Hi,

On 2023-03-30 17:15:20 -0400, Corey Huinker wrote:
> For those who already responded, are your concerns limited to the
> dependency issue? Would you have concerns about a templating library that
> was developed by us and included in-tree? I'm not suggesting suggesting we
> write one at this time, at least not until after we make a here-doc-ing
> pass first, but I want to understand the concerns before embarking on any
> refactoring.

The dependency is/was my main issue. But I'm also somewhat doubtful that what
we do warrants the use of a template library in the first place, but I could
be convinced by a patch showing it to be a significant improvement.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Refactor calculations to use instr_time
Next
From: Peter Geoghegan
Date:
Subject: Re: Add pg_walinspect function with block info columns