Re: fixing typo in comment for restriction_is_or_clause - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: fixing typo in comment for restriction_is_or_clause
Date
Msg-id 20221025073712.fjw6pcinzrz2u4um@alvherre.pgsql
Whole thread Raw
In response to Re: fixing typo in comment for restriction_is_or_clause  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: fixing typo in comment for restriction_is_or_clause  (Richard Guo <guofenglinux@gmail.com>)
List pgsql-hackers
On 2022-Oct-25, Richard Guo wrote:

> Agree with your point.  Do you think we can further make the one-line
> function a macro or an inline function in the .h file?

We can, but should we?

> I think this function is called quite frequently during planning, so
> maybe doing that would bring a little bit of efficiency.

You'd need to measure it and show some gains.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Issue in GIN fast-insert: XLogBeginInsert + Read/LockBuffer ordering
Next
From: Richard Guo
Date:
Subject: Re: fixing typo in comment for restriction_is_or_clause