Re: fixing typo in comment for restriction_is_or_clause - Mailing list pgsql-hackers

From Richard Guo
Subject Re: fixing typo in comment for restriction_is_or_clause
Date
Msg-id CAMbWs4-RXhgz0i4O1z62gt+bTLTM5vXYyYhgnius0j_txLH7hg@mail.gmail.com
Whole thread Raw
In response to Re: fixing typo in comment for restriction_is_or_clause  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers

On Tue, Oct 25, 2022 at 3:37 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2022-Oct-25, Richard Guo wrote:

> Agree with your point.  Do you think we can further make the one-line
> function a macro or an inline function in the .h file?

We can, but should we?

> I think this function is called quite frequently during planning, so
> maybe doing that would bring a little bit of efficiency.

You'd need to measure it and show some gains.
 
Yeah, that is what has to be done to make it happen.

Thanks
Richard

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: fixing typo in comment for restriction_is_or_clause
Next
From: Alvaro Herrera
Date:
Subject: Re: Proposal: Adding isbgworker column to pg_stat_activity