Postgres Pro
Downloads
Home   >   mailing lists

Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Date
Msg-id 20221004.152348.905742618983525147.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Tree view 
At Tue, 04 Oct 2022 15:17:06 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> Other than that, it looks good to me.

Sorry I have another comment.

> -            unsigned int tli,
> -                        log,
> -                        seg;
> +            unsigned int tli;
>              XLogSegNo    segno;

TLI should be of type TimeLineID.

This is not directly related to this patch, pg_resetwal.c has the
following line..

> static uint32 minXlogTli = 0;

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Next
From: Michael Paquier
Date:
Subject: Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file