Postgres Pro
Downloads
Home   >   mailing lists

Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Date
Msg-id YzvSpcONIe3gjrVp@paquier.xyz
Whole thread Raw
In response to Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Oct 04, 2022 at 03:17:06PM +0900, Kyotaro Horiguchi wrote:
> Nice finding. I found a few '%08X%08X's but they don't seem to fit
> similar fix.

Nice cleanup.

> Couldn't we use XLByteToSeg() here?
>
> Other than that, it looks good to me.

Yep.  It looks that you're right here.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Next
From: Peter Eisentraut
Date:
Subject: Re: Convert macros to static inline functions