Postgres Pro
Downloads
Home   >   mailing lists

Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.
Date
Msg-id 20220720133616.yc5qa3wo4i4vtwum@alvherre.pgsql
Whole thread Raw
In response to GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.  (Amul Sul <sulamul@gmail.com>)
Responses Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.
List pgsql-hackers
Tree view 
Hello

On 2022-Jul-20, Amul Sul wrote:

> If you look at GetFlushRecPtr() function the OUT parameter for
> TimeLineID is optional and this is not only one, see
> GetWalRcvFlushRecPtr(), GetXLogReplayRecPtr(), etc.
> 
> I think we have missed that for GetStandbyFlushRecPtr(), to be
> inlined, we should change this as follow:

This is something we decide mostly on a case-by-case basis.  There's no
fixed rule that all out params have to be optional.

If anything is improved by this change, let's see what it is.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Remove fls(), use pg_bitutils.h facilities instead?
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi