Re: Remove fls(), use pg_bitutils.h facilities instead? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove fls(), use pg_bitutils.h facilities instead?
Date
Msg-id 1690704.1658324077@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove fls(), use pg_bitutils.h facilities instead?  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> On Wed, Jul 20, 2022 at 4:52 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think we could probably just drop fls() entirely.  It doesn't look
>> to me like any of the existing callers expect a zero argument, so they
>> could be converted to use pg_leftmost_one_pos32() pretty trivially.

> That was not true for the case in contiguous_pages_to_segment_bin(),
> in dsa.c.  If it's just one place like that (and, hrrm, curiously
> there is an open issue about binning quality on my to do list...),

How is it sane to ask for a segment bin for zero pages?  Seems like
something should have short-circuited such a case well before here.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: PATCH: Add Table Access Method option to pgbench
Next
From: Alvaro Herrera
Date:
Subject: Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.