Re: PATCH: Add Table Access Method option to pgbench - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: PATCH: Add Table Access Method option to pgbench
Date
Msg-id CAPpHfdvsudAu8mecTSY2vcjK1GSzPfHKQ=hhPSnbV0WgbBjBbQ@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Add Table Access Method option to pgbench  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi!

On Tue, Jul 19, 2022 at 4:47 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Jul 18, 2022 at 01:53:21PM +0300, Alexander Korotkov wrote:
> > Looks good to me as well.  I'm going to push this if no objections.
>
> FWIW, I find the extra mention of PGOPTIONS with the specific point of
> table AMs added within the part of the environment variables a bit
> confusing, because we already mention PGOPTIONS for serializable
> transactions a bit down.  Hence, my choice would be the addition of an
> extra paragraph in the "Notes", named "Table Access Methods", just
> before or after "Good Practices".  My 2c.

Thank you.  Pushed applying the suggestion above.

------
Regards,
Alexander Korotkov



pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Support logical replication of DDLs
Next
From: Tom Lane
Date:
Subject: Re: Remove fls(), use pg_bitutils.h facilities instead?