Re: Replace l337sp34k in comments. - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Replace l337sp34k in comments.
Date
Msg-id 20210801211016.mzplr4cjuinsuaei@alap3.anarazel.de
Whole thread Raw
In response to Re: Replace l337sp34k in comments.  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Replace l337sp34k in comments.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Hi,

On 2021-07-31 12:15:34 +0300, Peter Geoghegan wrote:
> On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> > FWIW, my 2 cents.
> > I do not see much difference between up2date, up-to-date, up to date, current, recent, actual, last, newest,
correct,fresh etc.
 
> 
> +1.

> To me it seems normal to debate wording/terminology with new code
> comments, but that's about it. I find this zeal to change old code
> comments misguided. It's okay if they're clearly wrong or have typos.
> Anything else is just hypercorrection. And in any case there is a very
> real chance of making the overall situation worse rather than better.
> Probably in some subtle but important way.

Same here. I find them quite distracting, even.

It's one thing for such patches to target blindly obvious typos etc, but
they often also end up including less clear cut changes, which cost a
fair bit of time to review/judge.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: slab allocator performance issues
Next
From: Andrew Dunstan
Date:
Subject: Re: Replace l337sp34k in comments.