At Thu, 22 Apr 2021 23:17:19 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in
> Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> > All usages of pg_string_tolower don't need a copy.
> > So don't we change the function to in-place converter?
>
> Doesn't seem like a good idea, because that locks us into an assumption
> that the downcasing conversion doesn't change the string's physical
> length. There are a lot of counterexamples to that :-(. I'm not sure
Mmm. I didn't know of that.
> that we actually implement such cases correctly today, but let's not
> build APIs that prevent it from being fixed.
Agreed. Thanks for the knowledge.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
