Re: Split copy.c - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Split copy.c
Date
Msg-id 20201102172305.lz6a4jdcgslho5kj@alap3.anarazel.de
Whole thread Raw
In response to Split copy.c  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Split copy.c  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Hi,

On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> While looking at the parallel copy patches, it started to annoy me how large
> copy.c is.

Agreed.


> There isn't much common code between COPY FROM and COPY TO, so I propose
> that we split copy.c into two: copyfrom.c and copyto.c. See attached. I thin
> that's much nicer.

Not quite convinced that's the right split - or perhaps there's just
more potential. My feeling is that splitting out all the DML related
code would make the code considerably easier to read.


Regards,

Andres



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Add table AM 'tid_visible'
Next
From: Anastasia Lubennikova
Date:
Subject: Re: [proposal] de-TOAST'ing using a iterator