Re: Add table AM 'tid_visible' - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add table AM 'tid_visible'
Date
Msg-id 20201102171426.xuhc2hw3zsuv2mjy@alap3.anarazel.de
Whole thread Raw
In response to Add table AM 'tid_visible'  (Jinbao Chen <cjinbao@vmware.com>)
Responses Re: Add table AM 'tid_visible'  (Jinbao Chen <cjinbao@vmware.com>)
List pgsql-hackers
Hi,

On 2020-11-02 09:16:26 +0000, Jinbao Chen wrote:
> We directly call the heap function VM_ALL_VISIBLE in the
> IndexOnlyNext function. This is not in line with the design idea of
> table am. If the new storage type needs to implement index only
> scan, he must hack the IndexOnlyNext function.

Yea, it's something we should improve. Have you checked if this has
performance impact for heap? Should we also consider planning costs?


> So this patch add a new table am 'tid_visible' to test visibility
> of tid. So that index only scan can completely use table AM.

As far as I can tell you have not acually attached the patch.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: public schema default ACL
Next
From: Andres Freund
Date:
Subject: Re: Split copy.c