Re: Split copy.c - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Split copy.c
Date
Msg-id 57259272-fbc8-c318-eea9-88cb98e21527@iki.fi
Whole thread Raw
In response to Re: Split copy.c  (Andres Freund <andres@anarazel.de>)
Responses Re: Split copy.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 02/11/2020 19:23, Andres Freund wrote:
> On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
>> There isn't much common code between COPY FROM and COPY TO, so I propose
>> that we split copy.c into two: copyfrom.c and copyto.c. See attached. I thin
>> that's much nicer.
> 
> Not quite convinced that's the right split - or perhaps there's just
> more potential. My feeling is that splitting out all the DML related
> code would make the code considerably easier to read.

What do you mean by DML related code?

- Heikki



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: public schema default ACL
Next
From: Anastasia Lubennikova
Date:
Subject: Re: RE: Delaying/avoiding BTreeTupleGetNAtts() call within _bt_compare()