Hi,
On 2020-09-14 20:14:48 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I think the approach of having a long running psql session is really
> > useful, and probably would speed up some tests. Does anybody have a good
> > idea for how to best, and without undue effort, to integrate this into
> > PostgresNode.pm? I don't really have a great idea, so I think I'd leave
> > it with a local helper in the new test?
>
> You could use the interactive_psql infrastructure that already exists
> for psql/t/010_tab_completion.pl. That does rely on IO::Pty, but
> I think I'd prefer to accept that dependency for such tests over rolling
> our own IPC::Run, which is more or less what you've done here.
My test uses IPC::Run - although I'm indirectly 'use'ing, which I guess
isn't pretty. Just as 013_crash_restart.pl already did (even before
psql/t/010_tab_completion.pl). I am mostly wondering whether we could
avoid copying the utility functions into multiple test files...
Does IO::Pty work on windows? Given that currently the test doesn't use
a pty and that there's no benefit I can see in requiring one, I'm a bit
hesitant to go there?
Greetings,
Andres Freund
