Postgres Pro
Downloads
Home   >   mailing lists

Re: Suspicious strcmp() in src/backend/parser/parse_expr.c - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date
Msg-id 20190411021946.GG2728@paquier.xyz
Whole thread Raw
In response to Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Thomas Munro <thomas.munro@gmail.com>)
Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Tree view 
On Wed, Apr 10, 2019 at 06:43:32PM -0400, Tom Lane wrote:
> Indeed.  Considering how much I hate using strcmp's result as a boolean,
> you'd think I'd have got that right.  Thanks for noticing!

Just a note about those strcmp() calls using a boolean as return
result in the tree:
src/backend/commands/lockcmds.c: (!strcmp(rte->eref->aliasname, "old")
|| !strcmp(rte->eref->aliasname, "new")))
src/test/modules/test_rls_hooks/test_rls_hooks.c:   if
(strcmp(RelationGetRelationName(relation), "rls_test_permissive")
src/test/modules/test_rls_hooks/test_rls_hooks.c:       &&
strcmp(RelationGetRelationName(relation), "rls_test_both"))
src/test/modules/test_rls_hooks/test_rls_hooks.c:   if
(strcmp(RelationGetRelationName(relation), "rls_test_restrictive")
src/test/modules/test_rls_hooks/test_rls_hooks.c:       &&
strcmp(RelationGetRelationName(relation), "rls_test_both"))

Would it be worth changing these as well?
--
Michael
Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Next
From: Michael Paquier
Date:
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;