Postgres Pro
Downloads
Home   >   mailing lists

Re: Suspicious strcmp() in src/backend/parser/parse_expr.c - Mailing list pgsql-bugs

From Tom Lane
Subject Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date
Msg-id 12975.1554958549@sss.pgh.pa.us
Whole thread Raw
In response to Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
Tree view 
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Apr 10, 2019 at 06:43:32PM -0400, Tom Lane wrote:
>> Indeed.  Considering how much I hate using strcmp's result as a boolean,
>> you'd think I'd have got that right.  Thanks for noticing!

> Would it be worth changing these as well?

I'd be +1 for that, just on the grounds of having consistent coding
style.  But I'm not sufficiently excited about it to do the work
myself ...

            regards, tom lane

pgsql-bugs by date:

Previous
From: Jueve L
Date:
Subject: Re: BUG #15709: if drop exists syntax
Next
From: Pavel Stehule
Date:
Subject: Re: BUG #15709: if drop exists syntax